Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up for complex DOM versions #315

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Follow up for complex DOM versions #315

merged 2 commits into from
Sep 29, 2023

Conversation

issackjohn
Copy link
Contributor

@issackjohn issackjohn commented Sep 26, 2023 •
edited
Loading

This is a follow up for PR #264 plus some additional promised clean up. No changes to performance.

This PR includes the following changes:

  • adding comments
  • check that JSDOM is present
  • Perform prerequisites for building in the complex versions of the TodoMVC in the big-dom-generator BuildComplex utility function and handle them.
  • code clean up
  • remove dev dependency of jsdom in build script and move it to big-dom-generator BuildComplex Utility function

@issackjohn
Follow up for complex DOM versions. (#41)
cbab6de 
* add comments

* check that JSDOM is present

* Check prereqs in the build script and handle them

* group requires

* change the wording

* change some more format

* fix up rebase.

* add the prerequisite steps to the util function

* add code comment.

* code clean up

* follow up comment.

* use npm ci instead

* inline some constants

* spli up second argument.

* remove dev dependency
@issackjohn issackjohn requested a review from julienw September 26, 2023 19:45
@issackjohn
Copy link
Contributor Author

issackjohn commented Sep 26, 2023 •
edited
Loading

@julienw Could you PTAL, I've only made the changes to the Angular-Complex version. After we've reviewed and approved how we do it for Angular, I can perform the same changes to the rest of the build scripts.

julienw
julienw reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@julienw julienw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!
Can you please share a bit more the high-level purpose for this patch? My understanding is that this especially ensures that all dependencies are properly installed in all the related repositories. Can you please confirm?

@issackjohn
Copy link
Contributor Author

This looks good to me! Can you please share a bit more the high-level purpose for this patch? My understanding is that this especially ensures that all dependencies are properly installed in all the related repositories. Can you please confirm?

Yes, that's right. Previously a contributor would need to perform these steps manually before running npm run build in the complex version in order for it to work and might not know that you need to install the dependencies in big-dom-generator.

@issackjohn
Copy link
Contributor Author

issackjohn commented Sep 27, 2023 •
edited
Loading

When I build the Vue TodoMVC workload there are changes to the dist and I'm not sure why. Maybe the source files were updated but the dist wasn't rebuilt in a previous PR? Should I land a PR before this one that builds Vue TodoMVC or should I add it to this PR?

@issackjohn
Copy link
Contributor Author

@julienw, @rniwa Should I wait for more approvals or can I merge?

@rniwa
Copy link
Member

rniwa commented Sep 29, 2023

I think we technically want Google not being opposed to this change within 10 business days.

@issackjohn issackjohn merged commit 4316b5f into WebKit:main Sep 29, 2023
julienw
julienw reviewed Dec 21, 2023
View reviewed changes
resources/todomvc/architecture-examples/lit-complex/package.json
@@ -12,7 +12,6 @@
"devDependencies": {
"big-dom-generator": "file:../../big-dom-generator",
"http-server": "^14.1.1",
"jsdom": "^22.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that package-lock.json wasn't regenerated after this change, would it be possible to run npm i in all affected projects and commit package-lock.json?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#339

@issackjohn issackjohn mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienw julienw julienw approved these changes

@rniwa rniwa rniwa approved these changes

@flashdesignory flashdesignory flashdesignory approved these changes

@lpardosixtosMs lpardosixtosMs Awaiting requested review from lpardosixtosMs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@issackjohn @rniwa @flashdesignory @julienw